Changeset 3147

Timestamp:

02/02/2010 03:20:07 PM (5 weeks ago)

Author:

jackpoz

Message:

should fix:
==6017== Conditional jump or move depends on uninitialized value(s)
==6017== at 0x83280D3: Spell::FillAllTargetsInArea?(unsigned int, float, float, float, float) (Creature.h:585)
==6017== by 0x8320C2B: Spell::SpellTargetAreaOfEffect?(unsigned int, unsigned int) (SpellTarget?.cpp:451)
==6017== by 0x831CFE9: Spell::FillTargetMap?(unsigned int) (SpellTarget?.cpp:247)

Files:

• trunk/src/arcemu-world/Spell.cpp (modified) (1 diff)

trunk/src/arcemu-world/Spell.cpp

@@ -416 +416 @@
                 //maybe scripts can change list. Should use lock instead of this to prevent multiple changes. This protects to 1 deletion only
                 itr2++;
-                if( !( (*itr)->IsUnit() ) || ! static_cast< Unit* >( *itr )->isAlive() || ( static_cast< Creature* >( *itr )->IsTotem() && !static_cast< Unit* >( *itr )->IsPlayer() ) )
+                if( !( (*itr)->IsUnit() ) || ! static_cast< Unit* >( *itr )->isAlive() )//|| ( static_cast< Creature* >( *itr )->IsTotem() && !static_cast< Unit* >( *itr )->IsPlayer() ) ) why shouldn't we fill totems?
                         continue;